Implement soft delete for bounties (Closes #235)#343
Open
Halo11112222 wants to merge 2 commits intoGalactiGuild:mainfrom
Open
Implement soft delete for bounties (Closes #235)#343Halo11112222 wants to merge 2 commits intoGalactiGuild:mainfrom
Halo11112222 wants to merge 2 commits intoGalactiGuild:mainfrom
Conversation
- Add deletedAt filter to findOne, get, findAll, and search queries - Add remove() method that sets deletedAt timestamp instead of hard delete - Ensures deleted bounties don't appear in any listings
- Adds soft delete endpoint that calls service.remove() - Requires JWT auth (only creator can delete)
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! 👋
I saw the issue about soft deleting bounties and thought I'd take a crack at it.
What I changed:
In
bounty.service.ts:deletedAt: nullfilter tofindOne,get,findAll, andsearchqueries so deleted bounties never show up in listingsremove()method that setsdeletedAt = new Date()instead of doing a hard deleteIn
bounty.controller.ts:DELETE /bounties/:idendpoint that calls the newremove()methodThe schema already had the
deletedAtfield on the Bounty model, so I just had to wire up the filtering and the soft delete logic.Let me know if you'd like any changes! Happy to tweak the approach.